Re: [PATCH] platform/chrome: cros_ec: remove reference to nonexistent CONFIG_SLEEP_TIMEOUT_MS

Ethan Nelson-Moore <[email protected]>
Newsgroups dev.linux.lists.chrome-platform
Message-ID <CADkSEUgRvHMKy-7h6cTw-TqbpNiFZeSBXxXjhKgVfY3p3kp90w@mail.gmail.com>
Hi, Tzung-Bi,

On Mon, Jun 15, 2026 at 6:39 PM Tzung-Bi Shih <[email protected]> wrote:
> NACK.  This file is intended to stay in sync with the EC firmware header[1].
> While the CONFIG_SLEEP_TIMEOUT_MS is indeed unfortunate for a non-Kconfig
> macro in the kernel, we have historically kept it for consistency with the
> firmware code[2]."
>
> [1] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/include/ec_commands.h#5248
> [2] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/include/config.h#7178

Thank you for explaining this. There are a few other suspect CONFIG_*
symbol uses in Chrome EC code; I will check if they are also used by
the EC firmware before submitting patches to remove them.

Ethan
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.