Re: [PATCH 13/24] ASoC: codecs: cs35l56: Use guard() and PM runtime scope helpers

Bui Duc Phuc <[email protected]> Mon, 6 Jul 2026 16:31:36 +0700

Newsgroups	dev.linux.lists.chrome-platform,dev.linux.lists.asahi,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound
Message-ID	<CAABR9nEx4MCgBJNm-+jYLmAZJLPL-PoOXDwW_yUubHpdZQSJrw@mail.gmail.com>

Hi Richard,

Thank you for your review.

>
> Should change all the error returns to directly return IRQ_NONE.
> It looks like a bug that it checks rv but returns ret.
>
> The reason for ret was so it could use common exit code to
> pm_runtime_put() and mutex_unlock() for the error and success cases.
> But this isn't needed now.
>
> The local ret variable can be deleted.
>

I sent a v2 a few days ago.
https://lore.kernel.org/all/[email protected]/
Could you please take a look and review it as well?
If there are any remaining issues, I'll address them and send a v3.

Best regards,
Phuc