Re: [PATCH v2 00/24] ASoC: codecs: Use guard() for mutex & spin lock - part 1

On 7/3/2026 7:53 AM, [email protected] wrote:

...

> bui duc phuc (24):
>    ASoC: codecs: ab8500: Use guard() for mutex locks
>    ASoC: codecs: ak4613: Use guard() for mutex locks
>    ASoC: codecs: arizona-jack: Use guard() cleanup helpers
>    ASoC: codecs: arizona: Use guard() for mutex locks
>    ASoC: codecs: aw87390: Use guard() for mutex locks
>    ASoC: codecs: aw88081: Use guard() for mutex locks
>    ASoC: codecs: aw88166: Use guard() for mutex locks
>    ASoC: codecs: aw88261: Use guard() for mutex locks
>    ASoC: codecs: aw88395: Use guard() for mutex locks
>    ASoC: codecs: aw88399: Use guard() for mutex locks
>    ASoC: codecs: cros_ec_codec: Use guard() for mutex locks
>    ASoC: codecs: cs-amp-lib: Use guard() for mutex locks
>    ASoC: codecs: cs35l56: Use guard() and PM runtime scope helpers
>    ASoC: codecs: cs42l42: Use guard() cleanup helpers
>    ASoC: codecs: cs42l43: Use guard() and PM runtime scope helpers
>    ASoC: codecs: cs42l84: Use guard() for mutex locks
>    ASoC: codecs: cs43130: Use guard() for mutex locks
>    ASoC: codecs: cs47l15: Use guard() for mutex locks
>    ASoC: codecs: cs47l35: Use guard() for mutex locks
>    ASoC: codecs: cs47l85: Use guard() for mutex locks
>    ASoC: codecs: cs47l90: Use guard() for mutex locks
>    ASoC: codecs: cs47l92: Use guard() for mutex locks
>    ASoC: codecs: cs48l32: Use guard() for mutex locks
>    ASoC: codecs: cs2072x: Use guard() for mutex locks
Hi Phuc,

All the guard()-alone patches look good, the ones with PM runtime look 
monstrous - much harder to review.  Especially in 'cs42l43' and 
cs42l43_apply_accdet_config() case, I'd split the cleanup.

However, I'm not the one who will run the functional tests for these and 
from review-perspective, the patchset overall looks OK:

Reviewed-by: Cezary Rojewski <[email protected]>