Re: [PATCH v2 03/24] ASoC: codecs: arizona-jack: Use guard() cleanup helpers

Charles Keepax <[email protected]> Mon, 6 Jul 2026 13:58:40 +0100

Newsgroups	dev.linux.lists.chrome-platform,dev.linux.lists.asahi,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound
Message-ID	<[email protected]>

On Fri, Jul 03, 2026 at 12:53:34PM +0700, [email protected] wrote:
> From: bui duc phuc <[email protected]>
> 
> Clean up the code using guard() helpers for mutex locking
> and PM runtime management.
> No functional change intended.
> 
> Signed-off-by: bui duc phuc <[email protected]>
> ---
> @@ -1119,9 +1112,6 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
>  		     ARIZONA_JD1_FALL_TRIG_STS |
>  		     ARIZONA_JD1_RISE_TRIG_STS);
>  
> -	mutex_unlock(&info->lock);
> -
> -	pm_runtime_put_autosuspend(arizona->dev);
>  
>  	return IRQ_HANDLED;

Minor nit, this leaves a double blank line here.

Otherwise looks good to me:

Reviewed-by: Charles Keepax <[email protected]>

Thanks,
Charles