Re: [PATCH RFC v2 2/9] leds: cros_ec: Implement offloaded() callback for trigger
Thomas Weißschuh <[email protected]> Mon, 13 Jul 2026 22:28:04 +0200
| Newsgroups | dev.linux.lists.chrome-platform,org.kernel.vger.linux-doc,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds,org.kernel.vger.netdev,org.kernel.vger.platform-driver-x86 |
|---|---|
| Message-ID | <[email protected]> |
On 2026-06-18 00:47:56+0800, Rong Zhang wrote: > "chromeos-auto" is a private hardware control trigger which always stays > in hardware control. Implement offloaded() callback with its return > value to be always true to reflect this. > > Signed-off-by: Rong Zhang <[email protected]> Reviewed-by: Thomas Weißschuh <[email protected]> > --- > drivers/leds/leds-cros_ec.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/leds/leds-cros_ec.c b/drivers/leds/leds-cros_ec.c > index bea3cc3fbfd2..f48e3cf6ccf6 100644 > --- a/drivers/leds/leds-cros_ec.c > +++ b/drivers/leds/leds-cros_ec.c > @@ -86,12 +86,18 @@ static int cros_ec_led_trigger_activate(struct led_classdev *led_cdev) > return cros_ec_led_send_cmd(priv->cros_ec, &arg); > } > > +static bool cros_ec_led_trigger_offloaded(struct led_classdev *led_cdev) > +{ > + return true; > +} > + > static struct led_hw_trigger_type cros_ec_led_trigger_type; > > static struct led_trigger cros_ec_led_trigger = { > .name = "chromeos-auto", > .trigger_type = &cros_ec_led_trigger_type, > .activate = cros_ec_led_trigger_activate, > + .offloaded = cros_ec_led_trigger_offloaded, > }; > > static int cros_ec_led_brightness_set_blocking(struct led_classdev *led_cdev, > > -- > 2.53.0 >