[PATCH v2] platform/chrome: lightbar: Limit payload size to EC bounding macro
Alexis Savery <[email protected]> Wed, 29 Jul 2026 17:59:05 -0700
| Newsgroups | dev.linux.lists.chrome-platform |
|---|---|
| Message-ID | <[email protected]> |
The LIGHTBAR_CMD_SET_PROGRAM_EX command encapsulates its payload data with an 8-bit size field `uint8_t size` and is natively capped by the V3 packet bounds limit array `EC_LPC_HOST_PACKET_SIZE`. However, the driver currently allows the payload chunk to bypass this protocol limit if the SPI transmission layer negotiates a larger physical `max_request`. When this occurs, large payloads (e.g., >255 bytes) integer wrap the 8-bit size variable when assigning `param->set_program_ex.size`, causing truncation and parse failures downstream in the EC firmware stack. This change clamps max_size systematically using the `EC_LPC_HOST_PACKET_SIZE` macro, bringing chunking in sync with EC limits and preventing `uint8_t` size overflows. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexis Savery <[email protected]> --- drivers/platform/chrome/cros_ec_lightbar.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c index 02a6c34e68e6..052606cba85f 100644 --- a/drivers/platform/chrome/cros_ec_lightbar.c +++ b/drivers/platform/chrome/cros_ec_lightbar.c @@ -496,9 +496,14 @@ static ssize_t program_store(struct device *dev, struct device_attribute *attr, return -EINVAL; } } else { + /* + * The EC limits all version 3 host packets to EC_LPC_HOST_PACKET_SIZE. + */ extra_bytes = offsetof(typeof(*param), set_program_ex) + sizeof(param->set_program_ex); - max_size = ec->ec_dev->max_request - extra_bytes; + max_size = min_t(size_t, ec->ec_dev->max_request, + EC_LPC_HOST_PACKET_SIZE); + max_size -= extra_bytes; } msg = alloc_lightbar_cmd_msg(ec); -- 2.55.0.508.g3f0d502094-goog