Re: [PATCH v2] platform/chrome: cros_ec_proto: Fix deferred response
Tzung-Bi Shih <[email protected]>
| Newsgroups | dev.linux.lists.chrome-platform,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Aug 18, 2026 at 02:35:43PM -0400, Rob Barnes wrote:
> diff --git a/drivers/platform/chrome/cros_ec_proto.c
...
> static int cros_ec_wait_until_complete(struct cros_ec_device *ec_dev,
> - struct cros_ec_command *orig_msg)
> + struct cros_ec_command *orig_msg)
It looks like the patch was generated against to wrong base.
> @@ -171,8 +171,31 @@ static int cros_ec_wait_until_complete(struct
> cros_ec_device *ec_dev,
^^^^^^^^^^^^^^^^^^^^^^^
Please check your tools. The hunk header shouldn't wrap.
> @@ -185,7 +213,7 @@ static int cros_ec_send_command(struct
> cros_ec_device *ec_dev, struct cros_ec_co
./scripts/checkpatch.pl --strict:
ERROR: patch seems to be corrupt (line wrapped?)
> diff --git a/drivers/platform/chrome/cros_ec_proto_test.c
...
> @@ -2858,7 +3008,7 @@ static struct kunit_case cros_ec_proto_test_cases[] = {
> KUNIT_CASE(cros_ec_proto_test_cmd_xfer_protocol_v3_no_op),
> KUNIT_CASE(cros_ec_proto_test_cmd_xfer_protocol_v2_normal),
> KUNIT_CASE(cros_ec_proto_test_cmd_xfer_protocol_v2_no_op),
> - KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_normal),
> + KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_payload_0byte),
> KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_payload_4bytes),
> KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_payload_gt4bytes),
It looks like the patch was generated against to wrong base.