Re: [PATCH] iio: cros_ec: Convert to DEFINE_SIMPLE_DEV_PM_OPS()
Andy Shevchenko <[email protected]>
| Newsgroups | dev.linux.lists.chrome-platform,org.kernel.vger.linux-iio,org.kernel.vger.linux-kernel |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Fri, Aug 21, 2026 at 02:04:50PM +0000, Triet Hoang wrote: > On Fri, 21 Aug 2026 16:37:18 +0300, Andy Shevchenko wrote: > > There is a macro that combines DEFINE + EXPORT. > > Thanks for reviewing. Should I send the v2 with the update? v2 should incorporate the requested changes. > > There is room on the lines to make them longer a bit. > > > > Convert the deprecated SIMPLE_DEV_PM_OPS to DEFINE_SIMPLE_DEV_PM_OPS > > and pm_sleep_ptr(). > > > > This lets us drop the __maybe_unused annotations from the resume callbacks, > > and reduces kernel size in case CONFIG_PM or CONFIG_PM_SLEEP is disabled. > > With the new commit that you have suggested. It should be a new version of the same change, but with the comments being addressed. -- With Best Regards, Andy Shevchenko