Re: SVSM draft specification (v1.01 draft #3)
Carlos López <[email protected]> Wed, 12 Nov 2025 18:52:27 +0100
| Newsgroups | dev.linux.lists.coconut-svsm,dev.linux.lists.linux-coco |
|---|---|
| Message-ID | <[email protected]> |
Hi, On 10/3/25 6:01 PM, Tom Lendacky wrote: > Attached is the next version of the draft SVSM specification with the > following changes since the previous version: > > - APIC emulation protocol added > - Coconut-SVSM will need to be audited, as the current APIC emulation > code does not completely match the "Alternate Injection Support" > specification on which this protocol is based. Just one small comment on the APIC protocol, related to PR #850 [0]: the section for SVSM_APIC_WRITE_REGISTER states the behavior for invalid register addresses, but not for invalid values (e.g. an unsupported delivery mode in ICR in the case of that PR). I think this should be explicitly stated, and more precisely, I would suggest explaining whether the value of that register is changed or not if the write is rejected (I would assume it is not). Thanks, Carlos [0] https://github.com/coconut-svsm/svsm/pull/850