Re: [EXTERNAL] Re: [PATCH 4/4] kvm: svm: Support KVM_SEV_SNP_PAGE_TYPE_VMSA at SNP_LAUNCH_UPDATE
Jethro Beekman <[email protected]> Wed, 24 Jun 2026 00:35:39 +0200
| Newsgroups | dev.linux.lists.coconut-svsm,org.kernel.vger.kvm,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
--------------ms030903040004060902040409 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2026-06-24 00:02, Sean Christopherson wrote: > On Tue, Jun 23, 2026, Jethro Beekman wrote: >> On 2026-06-23 23:43, Sean Christopherson wrote: >>> On Tue, Jun 23, 2026, Jethro Beekman wrote: >>>> On 2026-06-23 16:51, Jon Lange wrote: >>>>> On Tuesday, June 23, 2026 6:40 AM, Sean Christopherson wrote: >>>>>> On Wed, Jun 17, 2026, J=C3=B6rg R=C3=B6del wrote: >>>>>>> On Wed, Jun 17, 2026 at 06:37:52AM -0700, Sean Christopherson wro= te: >>>>>>>> Ok, so it took us a few times to learn our lesson. I still don'= t see that as a >>>>>>>> strong argument for new uAPI, especially not for VMSA pages. I = am very firmly >>>>>>>> of the opinion that letting anything but the host kernel configu= re the VMSA is >>>>>>>> beyond stupid, but unfortunately we're stuck with AP_CREATION. = Expanding that >>>>>>>> surface has a very, very, VERY high bar to get over. >>>>>>> >>>>>>> The strongest argument in my view (and the main reason we are doi= ng this) is >>>>>>> actually the predictable launch measurement. On SEV-SNP this is a= requirement >>>>>>> to use platform VM-identity features like the ID Block. >>>>>> >>>>>> And I'm saying that unless KVM *can't* provide a predictable launc= h measurement, >>>>>> which AIUI isn't the case, then the launch measurement *must* be s= table across >>>>>> kernels because it's part of KVM's ABI. So as I see it, the issue= isn't that >>>>>> KVM is inherently unpredictable, it's that we lack tests to valida= te a thorny, >>>>>> subtle piece of KVM's ABI. >>>>> >>>>> Joerg is suggesting that we need a launch measurement that is stabl= e not >>>>> just across multiple launches on the same system, but across multip= le >>>>> hypervisors. >>>> >>>> If this is now suddenly an acceptable argument, please also merge ht= tps://lkml.org/lkml/2021/4/12/625 >>> >>> No, that's not how this works. Dave and Jarkko both have unanswered = questions >>> regarding the use case. Answer their questions, and I'm confident yo= u'll get >>> traction. >>> >>> : I don't believe we necessarily *WANT* or need Linux to support "al= l >>> : possible ECREATE, EADD, EEXTEND, EINIT sequences". Yet, it's what= is >>> : being used to justify this series without any other justification.= >>> :=20 >>> : It's going to be a different story if you bring me a real enclave = that >>> : *REALLY* wants to do this for good reasons. >>> >>> and >>> >>> : What specifically are you referring as the "rest of the world"? >>> :=20 >>> : That would be mean that there is reviewable workload "out there". >>> >>> The start of that thread is *exactly* what's playing out here. The b= ig difference, >>> and why this one's likely getting a different result, is that Jon pro= vided a very >>> thorough explanation of exactly what use case Joerg and company want = to support. >>> The only "assumed knowledge" is why it's desirable for the measuremen= t to be stable >>> across hypervisors, but I'm comfortable stitching that together on my= own. >>> >>> In other words, they aren't asking KVM to support every possible way/= time a VMSA >>> could be associated with a vCPU, they're asking to extend KVM to supp= ort a concrete >>> use case, with meaningful real world impact. In fact, I actually thi= nk this series >>> is *too* narrowly focused on their use case. >>> >>> FWIW, KVM_TDX_INIT_MEM_REGION has almost the exact same ABI that SGX = has: pages >>> contents are measured immediately after they're added. >> >> Sorry, the argument from Jon/Joerg is no different than the one we mad= e years >> ago for SGX. >> >> It was previously made abundantly clear that it's the kernel maintaine= rs's >> stance that it's sufficient to offer a UAPI that allows the creation o= f a >> Linux-specific subset of enclaves with a stable measurement encompassi= ng >> largely the enclave functionality available in the hardware. Or said a= nother >> way: if you can take your enclave and modify it to work with Linux, al= beit >> with a different measurement, that is acceptable. KVM-SNP is currently= at >> that state: it is currently completely possible to load VMs that were >> designed with the current Linux VMSA in IGVM format. >> >> A UAPI that allows creation of all architecturally-valid enclaves for >> purposes of measurement portability was stated as an explicit non-goal= =2E As >> this is the only stated purpose of this patch set, it should also not = be >> accepted. >=20 > No, the stated goals (thanks to the follow-up from Jon) are to (a) supp= ort VMSA > GPAs other than KVM's hardcoded, arbitrary 0xFFFFFFFFF000, and=20 As Jon points out, the VMSA GPA is not architecturally relevant, so any e= nclave can be changed to support a BSP VMSA at 0xFFFFFFFFF000. The only r= eason to "support VMSA GPAs other than KVM's hardcoded, arbitrary 0xFFFFF= FFFF000" is measurement portability. > (b) to play nice with multi-VMPL scenarios in the future. It's not clear to me what multi-VMPL scenario Jon is describing that requ= ires custom VMSA content/address at launch time other than measurement po= rtability. It's currently completely possible for VMPL0 code to set the V= MPL of a VMSA or create a new VMSA with VMPL>0 at any GPA of their choosi= ng. > If that happens to let userspace build > every architecturally possible VM, then yay!, we got lucky and probably= won't > ever need to revisit this. But "support every possibility" is not the = goal. --=20 Jethro Beekman | CTO | Fortanix --------------ms030903040004060902040409 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCC DVEwggZaMIIEQqADAgECAhA1+mGqtme9KUZNwz/3CNvGMA0GCSqGSIb3DQEBCwUAMH4xCzAJ BgNVBAYTAlVTMQ4wDAYDVQQIDAVUZXhhczEQMA4GA1UEBwwHSG91c3RvbjERMA8GA1UECgwI U1NMIENvcnAxOjA4BgNVBAMMMVNTTC5jb20gQ2xpZW50IENlcnRpZmljYXRlIEludGVybWVk aWF0ZSBDQSBSU0EgUjIwHhcNMjUxMDA2MTEwNzUyWhcNMjYxMDA2MTEwNzUyWjAkMSIwIAYJ KoZIhvcNAQkBFhNqZXRocm9AZm9ydGFuaXguY29tMIIBojANBgkqhkiG9w0BAQEFAAOCAY8A MIIBigKCAYEAsHHTT4CjC0VzCO7TK6hGJjaIpQjXsP7B9AznOt+ZyyeluwC145jlL+r6kYYG CvKHgK1sx4wIFTHiyiR9qCjigv6SG7guGTGSa2aHC0i8UV0p5z7uv41mfXpa9jbx3G6d7xcj HwrtcFC4XzBlgIDLgWliUR76bEx17fgdYSPQPX+IFGDHq1tWiknb9xUI47t2hTRtwJoK2qqr ekldESnznLRnDPTfq/MInS8oDjgpKyOOCwEbDjEUcvuLjQRkAj0AhDJi6LcKqOvmEexFzFlt M+NFlg6XPA2Xv/cNqYsNhznMEHI8iPU5VOLyEGQgdV/BduTVWlW2nVSJZMTpA66AtvqGVSTt 8ogDhez9yUXxPBQnc4yr1qggENthQDDIC/Sz9l0dU9GIFy89GJTPInZNNx/6t6ORa6XbTFHD X/IFLWvLuPLRPwS8O890P8G4KkuMRUS3FRP1R3l1igUbYSJwfSvtC8cgbUlHGiYvIb3tudch YYBBj9D420+zctemH/HPAgMBAAGjggGsMIIBqDAMBgNVHRMBAf8EAjAAMB8GA1UdIwQYMBaA FGaPpry3kyyd+bpJ5U/c6pBQEWqdMFcGCCsGAQUFBwEBBEswSTBHBggrBgEFBQcwAoY7aHR0 cDovL2NlcnQuc3NsLmNvbS9TU0xjb20tU3ViQ0EtY2xpZW50Q2VydC1SU0EtNDA5Ni1SMi5j ZXIwHgYDVR0RBBcwFYETamV0aHJvQGZvcnRhbml4LmNvbTBiBgNVHSAEWzBZMAkGB2eBDAEF AQIwPAYMKwYBBAGCqTABAwIBMCwwKgYIKwYBBQUHAgEWHmh0dHBzOi8vd3d3LnNzbC5jb20v cmVwb3NpdG9yeTAOBgwrBgEEAYKpMAEDBQcwHQYDVR0lBBYwFAYIKwYBBQUHAwIGCCsGAQUF BwMEMEwGA1UdHwRFMEMwQaA/oD2GO2h0dHA6Ly9jcmxzLnNzbC5jb20vU1NMY29tLVN1YkNB LWNsaWVudENlcnQtUlNBLTQwOTYtUjIuY3JsMB0GA1UdDgQWBBSe7dyiO5/YCMtvaDsV/9eu tMpB+DAOBgNVHQ8BAf8EBAMCBaAwDQYJKoZIhvcNAQELBQADggIBAORtEzFynaprV6QYTevg bsSZltHZXq4EAbweXFLmATzA7HO0UbPn0EkBV+hFA9tN1h3YI3gAtIK6ztRU6JzSyQ0T3w3h rRYEuo9yqMYlz3MiybGASg5P/paRzA+fUfYihZNEauwIEpNv2F0uAGow1G1lEOt0kljtCIjl cBK9zxM3uUqjPwH+a5xcng7Ir58THtGqE3EWjc79by36xu06AMExkNGOxyN3EJdpN0TGJ7pB bsRgm1PfiHSFRTunhKbzVLL82eyEimbt7ETTkU4/1SwEPKlkRznv0H1knJRzpX/NItoF4IjO Z2q3beenj2FUs2ButRX3jO1tKpMey2y9W0uF4rDz9ZOInHtHzg6qQ4houXP0EoO3FakDtK/O Zpg/W+FvYob6mwtwyd4S8TEZHqEsLoQ4WPF2MWM3VSiiXEIr66hxrkjkWv/wucj/pjo09zZr aus5lvBNdIhEQhS5lmYICr4Gr6Dd55/zAL7pgSOhbyRO0sp+8z9T1OUcukHd2utlbMDkI8oU G6uZpvxKY7ObZHm5EpkKkkZjSeZIhGy16IWT0RFgcz1D+tSdeX5jtS+xFQI8d5n/xn2st2eT bgjYlxfe8DI1ITlzP6aKccLRucSvJloiT85y6Hzs1T6nGcNQ3Hl9K9vj6GCfNjdCKNLMIYJR T1HVLSxFOrEyc3DCMIIG7zCCBNegAwIBAgIQB5/ciUBIivHZb9J0CmRVZjANBgkqhkiG9w0B AQsFADB8MQswCQYDVQQGEwJVUzEOMAwGA1UECAwFVGV4YXMxEDAOBgNVBAcMB0hvdXN0b24x GDAWBgNVBAoMD1NTTCBDb3Jwb3JhdGlvbjExMC8GA1UEAwwoU1NMLmNvbSBSb290IENlcnRp ZmljYXRpb24gQXV0aG9yaXR5IFJTQTAeFw0xOTAzMjYxNzQxMDZaFw0zNDAzMjIxNzQxMDZa MH4xCzAJBgNVBAYTAlVTMQ4wDAYDVQQIDAVUZXhhczEQMA4GA1UEBwwHSG91c3RvbjERMA8G A1UECgwIU1NMIENvcnAxOjA4BgNVBAMMMVNTTC5jb20gQ2xpZW50IENlcnRpZmljYXRlIElu dGVybWVkaWF0ZSBDQSBSU0EgUjIwggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQDm Q+3UxwVE9dAx75DUrLZwgASWLLr/ID8bbGCfpcrSHIRsrR4ut5n49JGViu5DYE6addkpajbi MA2Jaw1Ap4RncDjZ+0fzSWbqGKEE+vNPVLoKy7OVIrxf/9HzGUT6YaELSNrGTR0cYNcR+W5b E3JTxTMQiLMAwBbMXH4qKXQUT+oyIXD11CIMUtM8ECoo2o7qdpw1zaZWwVvhXy9mkAaRgrkw 2NpddZUVbJKF/spsJa3lNVdSi3wcJpDDQAl6jxtBF/3ctkY1OjBQz32yRlArFymsPc+we9ff HAgvfqbHVfXvgWG8urVith8/6MjmojHMCKqFoJueLbtTPoN8QhvVh49uoRYYAUUH0HOAYCOz GBGrdJvMIYZqQsX90XlU7Qxp1En7vMkQswkQTvGmBPWrK/EwSAJc15BZm+i8QBxPqVKFORfL ETLEC4ZrwomtW/oPxBP8zXPvQ0K1dQzAkw+JXxKv/KiwDryFFhU5xMMB3yKxO5NRYXlnqW9n wfhdBTJScthzAtGO9KZQ2GPmq0NMVMuXe1XdCOmnPxOptKkMldBItkaYgrkTzqP1nzIAhVfU 4sNnHIxKPftwrZ9VMSc5Wkz88bOtAJyz3KQRY0qcAtR4LaeRkiZaEmprQA8EOpdJxtv03pBZ taUnnTY6DsEwGQ0+P2mmB5IHB74SknyNswIDAQABo4IBaTCCAWUwEgYDVR0TAQH/BAgwBgEB /wIBADAfBgNVHSMEGDAWgBTdBAkHovV6fVJTEpKV7jiAJQ2mWTCBgwYIKwYBBQUHAQEEdzB1 MFEGCCsGAQUFBzAChkVodHRwOi8vd3d3LnNzbC5jb20vcmVwb3NpdG9yeS9TU0xjb21Sb290 Q2VydGlmaWNhdGlvbkF1dGhvcml0eVJTQS5jcnQwIAYIKwYBBQUHMAGGFGh0dHA6Ly9vY3Nw cy5zc2wuY29tMBEGA1UdIAQKMAgwBgYEVR0gADApBgNVHSUEIjAgBggrBgEFBQcDAgYIKwYB BQUHAwQGCisGAQQBgjcKAwwwOwYDVR0fBDQwMjAwoC6gLIYqaHR0cDovL2NybHMuc3NsLmNv bS9zc2wuY29tLXJzYS1Sb290Q0EuY3JsMB0GA1UdDgQWBBRmj6a8t5Msnfm6SeVP3OqQUBFq nTAOBgNVHQ8BAf8EBAMCAYYwDQYJKoZIhvcNAQELBQADggIBAMJr11ncGIPKbaZxuuU2P1TG yXF+gy+xH2TBNWNliJVL613nH1J7L2WcJQzqXYl77rKTzGeQexnKeYZ13MFwuE80vISif/gw K569WLoyCvNVvGEZ2bZ+JL5K49mVhrv1gqO+MgMvc8iEENl1xoWRpJGD4EClk8t4u7NUCgBv hYORiyzHCZcILHcEMvfEwmmFshMN6TqcAJdRjFT0Ru0hJcs5d7EFdM9dCa5ckXWrKK49cSNq 4qOaxqpG99EfDw6U2c70YcJ1/IhC1wL6z8qlGvhYQ0vJvqGJqW/DdeuWcMmrB+qZL9WbORQ1 nvlNggB6smEk0pXXYBr8HYjxT67XwtBBmkBXFpa7G6y4P0BO3kxWGBfvRBJHfyaiwREgVWa3 6V/WjXtPmV8VHcv04Rqgk64E4OlSUxgi9k9VC6kivTXJN+Gg2uJJBQdf+ptVhJqkkrtB0gAB F+kQP0xsagKkrS3NVrVKo6peWMx0h7l52bGqT8ucu4Qe200KQi2xp/r8jpP60EE9U4M8D1gr H3Kh9OxVOL4wykdoC/yGJNLKIl0BfsCVWB/GeSq5hxe/84K51OEJqpjDnOMrkRevfVzqGBFF Aeg7Kg7uSysVR05wR+ltp3ytaIbjGJtKad8raIbM1qiNFErG7YB7v4baI3BP1s/rTDtPLoto tahwHP7IqOHOMYIFVDCCBVACAQEwgZIwfjELMAkGA1UEBhMCVVMxDjAMBgNVBAgMBVRleGFz MRAwDgYDVQQHDAdIb3VzdG9uMREwDwYDVQQKDAhTU0wgQ29ycDE6MDgGA1UEAwwxU1NMLmNv bSBDbGllbnQgQ2VydGlmaWNhdGUgSW50ZXJtZWRpYXRlIENBIFJTQSBSMgIQNfphqrZnvSlG TcM/9wjbxjANBglghkgBZQMEAgEFAKCCAxIwGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAc BgkqhkiG9w0BCQUxDxcNMjYwNjIzMjIzNTM5WjAvBgkqhkiG9w0BCQQxIgQgV6Ld6i7ubIeK v7lFqh4UGGJ7O7gqw1KV+m6U/Tud0DQwgaMGCSsGAQQBgjcQBDGBlTCBkjB+MQswCQYDVQQG EwJVUzEOMAwGA1UECAwFVGV4YXMxEDAOBgNVBAcMB0hvdXN0b24xETAPBgNVBAoMCFNTTCBD b3JwMTowOAYDVQQDDDFTU0wuY29tIENsaWVudCBDZXJ0aWZpY2F0ZSBJbnRlcm1lZGlhdGUg Q0EgUlNBIFIyAhA1+mGqtme9KUZNwz/3CNvGMIGlBgsqhkiG9w0BCRACCzGBlaCBkjB+MQsw CQYDVQQGEwJVUzEOMAwGA1UECAwFVGV4YXMxEDAOBgNVBAcMB0hvdXN0b24xETAPBgNVBAoM CFNTTCBDb3JwMTowOAYDVQQDDDFTU0wuY29tIENsaWVudCBDZXJ0aWZpY2F0ZSBJbnRlcm1l ZGlhdGUgQ0EgUlNBIFIyAhA1+mGqtme9KUZNwz/3CNvGMIIBVwYJKoZIhvcNAQkPMYIBSDCC AUQwCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzANBggqhkiG9w0DAgIB BTANBggqhkiG9w0DAgIBBTAHBgUrDgMCBzANBggqhkiG9w0DAgIBBTAHBgUrDgMCGjALBglg hkgBZQMEAgEwCwYJYIZIAWUDBAICMAsGCWCGSAFlAwQCAzALBglghkgBZQMEAgQwCwYJYIZI AWUDBAIHMAsGCWCGSAFlAwQCCDALBglghkgBZQMEAgkwCwYJYIZIAWUDBAIKMAsGCSqGSIb3 DQEBATALBgkrgQUQhkg/AAIwCAYGK4EEAQsAMAgGBiuBBAELATAIBgYrgQQBCwIwCAYGK4EE AQsDMAsGCSuBBRCGSD8AAzAIBgYrgQQBDgAwCAYGK4EEAQ4BMAgGBiuBBAEOAjAIBgYrgQQB DgMwDQYJKoZIhvcNAQEBBQAEggGAZw8NcalnsW+nU+RngtoKYxKzTJrKtiDejokkbK9dbUAU dp1lXOugz8VQOEsMJ+WeJzGtAQyuMvwYv3EkFL4N/qJGxENf09yCr7rmG9g0uXtcOv6zQ2UV 7A/S1I8Etyl7U5aK3/EeSIvEZBIhsVl9c7EtGGV6dNiVCEcHBMHra3k5KYRsyraw3n+/ZJXt IM2Zq8VLIEznBLHB/43btbTvvh0iTqL63S/+Z7IetvhLOQQlxoS+1NzJqwKArVYX2jB9Svpk TxpYnE3aR/0Dh1nRdS98GBGdvvgWbKF/ekQRd7P6v/xPy9Xjs2lILOX/XUIs6YNeZYHks5GU JMH1D71pofo39X1N+Lxt0nwqWleoujb6VwoL8ru8tOc5M9tPAHcyjLeqRDxm0KvN1yMnW6QL THofWvNxoFJMMdr4jVNs4KqTOi9RCzHCqS2MyFHGCl1Q4H0XRmZgs/Qs3AuGDGBJDyI1AE1g 8i69/JouPEGtMcdS58gjSvXnNPCHO34iIGbSAAAAAAAA --------------ms030903040004060902040409--