Re: [PATCH 0/5] Address Unhandled Gateway Route Lifecycle Events/Transitions
Marcel Holtmann <[email protected]>
| Newsgroups | dev.linux.lists.connman |
|---|---|
| Message-ID | <[email protected]> |
Hi Grant,
> There were a number of "escapes" or unhandled events and transitions
> that did not adhere to the documented gateway configuration lifecycle
> / state machine.
>
> Failure to handle these was resulting in duplicate default routes, no
> default routes, and incorrect default route priorities for some
> services and their underlying network interfaces.
>
> These "escapes" were handled in three primary ways with this patch series:
>
> 1. Leveraging '__connman_inet_rtnl_recv' in 'iproute_default_modify'.
> 2. Leveraging -ESRCH returned by 'iproute_default_modify'.
> 3. Adding explicit conditional cases for the "escapes" not otherwise
> covered by (1) and (2).
>
> Grant Erickson (5):
> inet: Use '__connman_inet_rtnl_recv' for RTNL default route
> transaction.
> gateway: Handle -ESRCH in 'unset_default_gateway_route_common'.
> gateway: Address unhandled gateway lifecycle events/transitions.
> gateway: Add and leveage 'gateway_config_set_{,in}active'.
> gateway: Expand the @param documentation for
> 'yield_default_gateway{,_for_type}'.
>
> src/gateway.c | 80 +++++++++++++++++++++++++++++++++++++++------------
> src/inet.c | 6 ++++
> 2 files changed, 68 insertions(+), 18 deletions(-)
all 5 patches have been applied.
Regards
Marcel