[PATCH 01/11] agent: Cancel agent request on NoReply D-Bus error
Jussi Laakkonen <[email protected]>
| Newsgroups | dev.linux.lists.connman |
|---|---|
| Message-ID | <[email protected]> |
Handle also the NoReply D-Bus error as this is commonly sent back when
the timeout set for the request is exceeded. Canceling the request later
becomes impossible as agent->pending will be set to NULL in
agent_finalize_pending(). Thus, making later calls to
connman_agent_cancel() to not to close down agent dialogs but instead
they are piled up on top of each other.
---
src/agent.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/agent.c b/src/agent.c
index 23517d9b..e2d1ef09 100644
--- a/src/agent.c
+++ b/src/agent.c
@@ -201,7 +201,9 @@ static void agent_receive_message(DBusPendingCall *call, void *user_data)
if (dbus_message_is_error(reply,
"org.freedesktop.DBus.Error.Timeout") ||
dbus_message_is_error(reply,
- "org.freedesktop.DBus.Error.TimedOut")) {
+ "org.freedesktop.DBus.Error.TimedOut") ||
+ dbus_message_is_error(reply,
+ "org.freedesktop.DBus.Error.NoReply")) {
send_cancel_request(agent, agent->pending);
}
--
2.39.5