[PATCH 4/8] vpn: Fix mem leak on nameservers

Jussi Laakkonen <[email protected]> Thu, 10 Apr 2025 18:58:42 +0300
Newsgroups dev.linux.lists.connman
Message-ID <[email protected]>
Fix Clang analyzer complaint about mem leak on nameservers.
---
 plugins/vpn.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/plugins/vpn.c b/plugins/vpn.c
index 9664c82f..9e6e26bf 100644
--- a/plugins/vpn.c
+++ b/plugins/vpn.c
@@ -472,8 +472,10 @@ static int extract_nameservers(DBusMessageIter *array,
 		DBG("[%d] %s", i, nameserver);

 		nameservers[i] = g_strdup(nameserver);
-		if (!nameservers[i])
+		if (!nameservers[i]) {
+			g_strfreev(nameservers);
 			return -ENOMEM;
+		}

 		nameservers[++i] = NULL;

--
2.39.5