Re: [PATCH V2] timezone: Fix compare_file comparison in timezone checking

Denis Kenzior <[email protected]> Thu, 15 May 2025 12:51:48 -0500
Newsgroups dev.linux.lists.connman
Message-ID <[email protected]>
Hi Michael,

On 5/15/25 6:44 AM, Michael Trimarchi wrote:
> The original condition incorrectly returned -1 when the real path and the
> provided pathname matched, due to a flawed use of `g_strcmp0`. This patch
> corrects the logic to return 0 (success) when the paths match, ensuring
> proper file comparison behavior.
> 
> Signed-off-by: Andrea Ricchi <[email protected]>
> Signed-off-by: Michael Trimarchi <[email protected]>

No Signed-off-by used by ConnMan, I dropped these.

> ---
> V1->V2: Improve commit message
> ---
>   src/timezone.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Regards,
-Denis