Re: [PATCH 2/3] technology: Leverage 'DefaultEnabledTechnologies' setting.

On Aug 4, 2025, at 11:27 AM, Denis Kenzior <[email protected]> wrote:
> On 7/28/25 5:32 PM, Grant Erickson wrote:
>> This leverages the new 'DefaultEnabledTechnologies' configuration
>> setting.
>> ---
>>  src/technology.c | 25 +++++++++++++++----------
>>  1 file changed, 15 insertions(+), 10 deletions(-)
> 
> <snip>
> 
>> @@ -429,19 +429,27 @@ static void technology_load(struct connman_technology *technology)
>>   GKeyFile *keyfile;
>>   gchar *identifier;
>>   GError *error = NULL;
>> - bool enable, need_saving = false;
>> + bool enable, need_saving = false, enable_persistent = false;
>>   char *enc;
>> + int i;
>> + unsigned int *enabled_types;
>>     DBG("technology %p", technology);
>>  + /* Determine which technology types are enabled by default */
>> +
>> + enabled_types = connman_setting_get_uint_list("DefaultEnabledTechnologies");
> 
> I amended this patch slightly to avoid > 80 character line.  I moved this initializer to the variable declaration block.

Thank you.

> Perhaps instead of duplicating these strings everywhere, the CONF_* defines should move somewhere as public API?

Fully agreed. Do you have any preferences on where?

Best,

Grant

-- 
Principal
Nuovations

[email protected]
https://www.nuovations.com/