Re: [PATCH] Adjust printf(3) formats for 32-bit platforms

Hi

On 7/21/25 9:17 AM, Łukasz Stelmach wrote:
> On 32-bit platforms time_t may be defined as long long int to make it
> 64-bit wide and y2038 compatible. On 64-bit platform with LP64 data model
> ABI long long is also 64-bit, so it is convenient and safe to always
> cast time_t to long long and use %lld/%llu format on all platforms.
> 
> Signed-off-by: Łukasz Stelmach <[email protected]>

No Signed-off-by used by ConnMan.

> ---
>   src/device.c  |  8 +++++---
>   src/dhcpv6.c  | 10 ++++++----
>   src/log.c     |  2 +-
>   src/ntp.c     |  5 +++--
>   src/service.c |  9 +++++----
>   5 files changed, 20 insertions(+), 14 deletions(-)
> 
> These adjustments were made in response to gcc complaints about improper
> arguments for printf-like calls. I haven't checked manually all the
> calls in the code and haven't changed those which were not compiled due
> to #if-s and #ifdef-s.

Makes sense, but the patch doesn't apply.  Perhaps you're using some special 
sauce on top of upstream ConnMan?

[denkenz@archdev connman]$ git am ~/merge/\[PATCH]\ Adjust\ printf\(3\)\ 
formats\ for\ 32-bit\ platforms\ -\ Łukasz\ Stelmach\ 
\<l.stelmach\@samsung.com\>\ -\ 2025-07-21\ 0917.eml
Applying: Adjust printf(3) formats for 32-bit platforms
warning: src/device.c has type 100644, expected 100755
error: patch failed: src/device.c:896
error: src/device.c: patch does not apply
warning: src/dhcpv6.c has type 100644, expected 100755
warning: src/log.c has type 100644, expected 100755
error: patch failed: src/log.c:149
error: src/log.c: patch does not apply
warning: src/ntp.c has type 100644, expected 100755
error: patch failed: src/ntp.c:406
error: src/ntp.c: patch does not apply
warning: src/service.c has type 100644, expected 100755
error: patch failed: src/service.c:844
error: src/service.c: patch does not apply
Patch failed at 0001 Adjust printf(3) formats for 32-bit platforms
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Regards,
-Denis