Re: [PATCH] Fix comparison of services of same preferred type

[email protected] Mon, 04 Aug 2025 19:30:05 +0000
Newsgroups dev.linux.lists.connman
Message-ID <175433580501.1326904.11547972624192042088.git-patchwork-notify@kernel.org>
Hello:

This patch was applied to connman.git (master)
by Denis Kenzior <[email protected]>:

On Fri,  1 Aug 2025 13:02:39 +0200 you wrote:
> The service_compare_preferred() function is called twice in
> service_compare(), once with a guard to only use it on services with
> differing types, but once without any such guard. In the latter case,
> when comparing two services of the same preferred technology, it always
> returns -1 because it checks service_a first and exits immediately, when
> one would normally expect that comparison to result in a tie (return
> value 0).
> 
> [...]

Here is the summary with links:
  - Fix comparison of services of same preferred type
    https://git.kernel.org/pub/scm/network/connman/connman.git/?id=82ce27e45308

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html