Re: [PATCH 23/45] util: Add address family set/get/reset helpers

Hi Denis,

On 8/4/25 17:47, Denis Kenzior wrote:
> Hi Jussi,
> 
> On 7/11/25 9:27 AM, Jussi Laakkonen wrote:
>> [util] Add address family set/get/reset helpers. JB#62713
> 
> I don't know what this is.  Please drop any references to internal 
> tickets when submitting and spell out what the commit is trying to do in 
> the commit description.

Oops I apparently missed one here. We have the internal tickets on every 
commit so 1/46 was a simple oversight. I'll remove it and put v2 next week.

> 
>>
>> Add address family (af) helper functions to be used with a boolean array
>> defining which address families a provider has. Supports AF_INET and
>> AF_INET6 as set/get parameters. The array must be of AF_ARRAY_LENGTH
>> size.
> 
> Ugh, seriously?  Maybe:
> bool support_ipv6 : 1;
> bool support_ipv4 : 1;
> 
> ?

Yeah it can be made into a struct for sure. I'll make V2 of related 
changes (hopefully) next week.

> 
>> ---
>>   src/shared/util.c | 40 ++++++++++++++++++++++++++++++++++++++++
>>   src/shared/util.h | 11 +++++++++++
>>   2 files changed, 51 insertions(+)
>>
> 
> Regards,
> -Denis

BR,
  Jussi