[PATCH v2 17/42] vpn: Drop state changes from update_provider_state()
Jussi Laakkonen <[email protected]> Wed, 13 Aug 2025 18:01:49 +0300
| Newsgroups | dev.linux.lists.connman |
|---|---|
| Message-ID | <[email protected]> |
It is not necessary to change the state in vpn.c for non-daemon VPNs because the vpn-provider.c:__vpn_provider_connect() changes the state according to the state machine. ASSOCIATION state will be assigned for every VPN after connect, then depending on VPN agent use the state changes either directly, or after the agent has finished, to CONNECT state. --- vpn/plugins/vpn.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/vpn/plugins/vpn.c b/vpn/plugins/vpn.c index 9ff2ad6c..8f04ceb6 100644 --- a/vpn/plugins/vpn.c +++ b/vpn/plugins/vpn.c @@ -556,8 +556,6 @@ static gboolean update_provider_state(gpointer data) vpn_data->watch = vpn_rtnl_add_newlink_watch(index, vpn_newlink, provider); connman_inet_ifup(index); - vpn_data->state = VPN_STATE_CONNECT; - vpn_provider_set_state(provider, VPN_PROVIDER_STATE_CONNECT); return FALSE; } -- 2.39.5