Re: [PATCH v2 00/42] VPN association state, dual IP support and WG fixes

Jussi Laakkonen <[email protected]> Fri, 21 Nov 2025 17:36:45 +0200
Newsgroups dev.linux.lists.connman
Message-ID <[email protected]>
Hi Christian and all,


On 10/29/25 3:40 AM, Christian Hewitt wrote:
>> On 13 Aug 2025, at 7:01 pm, Jussi Laakkonen <[email protected]> wrote:
>>
>> This patch set (1) adds the association state also for the VPNs, (2) implements
>> dual IP support for VPNs and (3) contains fixes for Wireguard address,
>> especially for FQDN handling. This is a combination of all three improvements
>> for the sake of testing them together.
> 
> [snip]
> 
> Patch 21/42 #includes both inet.h and arpa/inet.h; the former results in a
> compile error. This change resolves it:

Oops, I guess this was missed in refactoring. Good catch, I just sent a 
v3 fixing this.

> 
> diff --git a/src/shared/util.h b/src/shared/util.h
> index baaca31e..30630f93 100644
> --- a/src/shared/util.h
> +++ b/src/shared/util.h
> @@ -25,7 +25,6 @@
>     #include <glib.h>
>   #include <stdbool.h>
> -#include <inet.h>
>   #include <arpa/inet.h>
>     typedef void (*util_debug_func_t)(const char *str, void *user_data);
> 
> With that nit solved I was running the series for several months with
> no issues. However the latest ConnMan release now gives me connection
> problems and although patches still compile I had to revert them. I’ve
> not yet had time to bisect and find the breaking change.
> 
Hm, I can at some point try to check it myself when time allows. Good to 
know this, might it be my change or some change merged in master that 
causes this? And may I ask what kind of connection problems you are facing?

Cheers,
  Jussi