Re: client: set rl_prompt after saving
Justin Bronder <[email protected]> Tue, 24 Mar 2026 20:57:56 -0400
| Newsgroups | dev.linux.lists.connman |
|---|---|
| Message-ID | <[email protected]> |
On 18/10/25 17:24 -0400, Justin Bronder wrote:
> Readline 8.3 crashes when rl_save_prompt() is called without
> rl_set_prompt() being called first [1]. This means that interactive
> connmanctl immediately crashes upon invocation. As we're about to clear
> the line anyways, we can just set the buffer to an empty string as well.
>
> Alternatively, I believe that both rl_set_prompt() and rl_replace_line()
> could be replaced by a call to rl_message("") but I don't want to
> expand the scope of this patch.
>
> 1. https://lists.gnu.org/archive/html/bug-readline/2025-07/msg00007.html
Hi,
Just checking in on if this patch is appropriate for merging or if outside contributions are not accepted? I assumed that connmanctl immediately segfaulting with readline 8.3 would be something that would be fixed on a bit shorter of a timeline.
I'm sitting on changes that I'd like to push up to openSUSE, but if this project isn't supported there, I can just drop them.
Best,
--
Justin Bronder