Re: [PATCH 00/25] Amdgpu plugin cleanups and fixes

Sorry for the delay

These five more patches are

Reviewed-By: David Francis <[email protected]>

________________________________________
From: Tvrtko Ursulin <[email protected]>
Sent: Thursday, April 9, 2026 5:41 AM
To: [email protected]
Cc: Francis, David
Subject: Re: [PATCH 00/25] Amdgpu plugin cleanups and fixes


On 11/03/2026 09:58, Tvrtko Ursulin wrote:
> This series is a subset of previously posted:
> https://lore.kernel.org/criu/CAEWA0a4ghpPeQjg1ETiQysGj5agfWwJRvMbWzhrYL5r8WZ5H7Q@mail.gmail.com/T/#mfb4ab4866a0cb440961be7170d0e107fab7eedf2
>
> It only contains the fixes and cleanups with the render node hacks removed.
>
> Most of the patches have already been reviewed, with just five new ones, since I
> did find some more problems, mostly around incorrect usage of pr_perror and some
> helpers not using the errno correctly. One of the patches reduces the amount of
> pr_debug in normal operation as agreed during the review of the above linked
> series.
>
> The new patches are these:
>    plugins/amdgpu: Reduce amount of debug logging a little bit
>    plugins/amdgpu: Do not eat the errno in kmtIoctl
>    plugins/amdgpu: Fix open_drm_render_device()
>    plugins/amdgpu: Check sdma operation type early and once
>    plugins/amdgpu: Fix remaining wrong usages of pr_perror
>
> Intent is to hopefully get those remaining ones reviewed, merge the series, and
> then proceed with the more complicated design work for properly supporting pure
> render node applications.

Gentle ping on the above unreviewed patches.

Thanks,

Tvrtko

> Tvrtko Ursulin (25):
>    plugins/amgdpu: Fix one error message
>    plugins/amdgpu: Remove unused current_pid global variable
>    plugins/amdgpu: Remove unused new_minor from struct vma_metadata
>    plugins/amdgpu: Fix drm pages size header
>    plugins/amdgpu: Fix logging of failures to open files during restore
>      init
>    plugins/amdgpu: Propagate failure to save buffer object content
>    plugins/amdgpu: Close the directory when image probing fails
>    plugins/amdgpu: Close dma-buf image file if the read fails
>    plugins/amdgpu: Check images were opened successfully
>    plugins/amdgpu: Flatten amdgpu_restore_init a bit
>    plugins/amdgpu: Fix error handling in amdgpu_plugin_drm_restore_file()
>    plugins/amdgpu: Add error handling for seek operations
>    plugins/amdgpu: Consolidate vm_info collection
>    plugins/amdgpu: Remove plugin_log_msg()
>    plugins/amdgpu: Reduce amount of debug logging a little bit
>    plugins/amdgpu: Do not eat the errno in kmtIoctl
>    plugins/amdgpu: Fix open_drm_render_device()
>    plugins/amdgpu: Check sdma operation type early and once
>    plugins/amdgpu: Add plugin to inventory even if process has no vmas
>    plugins/amdgpu: Move drm file dump and restore into helpers
>    plugins/amdgpu: Use the load_img helper in drm file restore
>    plugins/amdgpu: Convert away from libc buffered file IO
>    plugins/amdgpu: Use save_vma_updates for all call sites
>    plugins/amdgpu: amdgpu_plugin_drm_restore_file() does not need to use
>      libdrm
>    plugins/amdgpu: Fix remaining wrong usages of pr_perror
>
>   plugins/amdgpu/amdgpu_plugin.c          | 763 ++++++++++++------------
>   plugins/amdgpu/amdgpu_plugin_dmabuf.c   |  17 +-
>   plugins/amdgpu/amdgpu_plugin_drm.c      | 124 ++--
>   plugins/amdgpu/amdgpu_plugin_drm.h      |   3 +-
>   plugins/amdgpu/amdgpu_plugin_topology.c |  21 +-
>   plugins/amdgpu/amdgpu_plugin_util.c     | 106 ++--
>   plugins/amdgpu/amdgpu_plugin_util.h     |  17 +-
>   7 files changed, 540 insertions(+), 511 deletions(-)
>