[PATCH v2 08/23] plugins/amdgpu: Close dma-buf image file if the read fails

Consolidate to one fclose() call with the extra bonus the inconsequential
file descriptor leak is eliminated.

Signed-off-by: Tvrtko Ursulin <[email protected]>
Reviewed-By: David Francis <[email protected]>
---
 plugins/amdgpu/amdgpu_plugin_dmabuf.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/plugins/amdgpu/amdgpu_plugin_dmabuf.c b/plugins/amdgpu/amdgpu_plugin_dmabuf.c
index e76628cc2faf..312c9f95d048 100644
--- a/plugins/amdgpu/amdgpu_plugin_dmabuf.c
+++ b/plugins/amdgpu/amdgpu_plugin_dmabuf.c
@@ -120,6 +120,7 @@ int amdgpu_plugin_dmabuf_restore(int id)
 	}
 
 	ret = read_fp(img_fp, buf, img_size);
+	fclose(img_fp);
 	if (ret) {
 		pr_perror("Unable to read from %s", path);
 		xfree(buf);
@@ -130,10 +131,8 @@ int amdgpu_plugin_dmabuf_restore(int id)
 	if (rd == NULL) {
 		pr_perror("Unable to parse the dmabuf message %d", id);
 		xfree(buf);
-		fclose(img_fp);
 		return -1;
 	}
-	fclose(img_fp);
 
 	/* Match GEM handle with shared_dmabuf list */
 	fd_id = amdgpu_id_for_handle(rd->gem_handle);
-- 
2.52.0