Re: [PATCH] damon: update outdated comment about DAMOS filter handling

SJ Park <[email protected]>
Newsgroups dev.linux.lists.damon,org.kernel.vger.linux-kernel,org.kvack.linux-mm
Message-ID <[email protected]>
On Wed, 15 Jul 2026 17:26:34 +0800 Song Hu <[email protected]> wrote:

> The kernel-doc comment above enum damos_filter_type states that only the
> anon and memcg type filters are handled by damon_operations (and therefore
> accounted as 'tried'), and that DAMON_OPS_VADDR and DAMON_OPS_FVADDR do
> not support those two filter types.
> 
> Neither is accurate anymore.  damos_filter_for_ops() routes every filter
> type except ADDR and TARGET to the operations layer, and the VADDR and
> FVADDR operations (the latter being a copy of the former) handle all of
> those types through damos_folio_filter_match() / damos_va_filter_out().
> Update the comment to match the code.

Thank you for updating this!
> 
> Signed-off-by: Song Hu <[email protected]>

Reviewed-by: SJ Park <[email protected]>

This patch is applied to damon/next [1] tree.  If this patch is not added to
mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton)
to pick this.  So, no action from your side is needed for now.  If it seems I
also forgot doing that or you cannot wait for my action, please feel free to
directly ask that to Andrew.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.