Re: [PATCH] samples/damon/prcl: add module parameter description for target_pid

SJ Park <[email protected]>
Newsgroups dev.linux.lists.damon,org.kvack.linux-mm
Message-ID <[email protected]> 
Hello Enze,


Thank you for this patch!

On Thu, 16 Jul 2026 17:14:44 +0800 Enze Li <[email protected]> wrote:

> Document 'target_pid' via MODULE_PARM_DESC so its meaning is visible
> through kernel command line usage and sysfs interface.

But...  It is a static module.  Is there a way to read this documentation from
the user space?  If there is no such a way, I don't really think this change is
needed.  If we want to document this, we could use comments.

I show 'enabled' parameter has MODULE_PARM_DESC().  If the inconsistency is a
problem, I think it might be better to consistently remove MODULE_PARM_DESC().
It may also be beneficial to comment why we don't have MODULE_PARM_DESC()s on
the module.  What do you think?


Thanks,
SJ

[...]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.