Re: [PATCH] samples/damon/prcl: add module parameter description for target_pid
Enze Li <[email protected]>
| Newsgroups | dev.linux.lists.damon |
|---|---|
| Message-ID | <[email protected]> |
Hi SJ, Thank you for your review. On Thu, Jul 16 2026 at 06:54:37 AM -0700, SJ Park wrote: > Hello Enze, > > > Thank you for this patch! > > On Thu, 16 Jul 2026 17:14:44 +0800 Enze Li <[email protected]> wrote: > >> Document 'target_pid' via MODULE_PARM_DESC so its meaning is visible >> through kernel command line usage and sysfs interface. > > But... It is a static module. Is there a way to read this documentation from > the user space? If there is no such a way, I don't really think this change is > needed. If we want to document this, we could use comments. AFAIK, MODULE_PARM_DESC() is for loadable modules. For builtins, it’s effectively just a comment. That said, if DAMON gains loadable module support later, having these descriptors in place means we won’t need to touch the code. WDYT? Thanks, Enze <...>