Re: [PATCH] mm/damon/ops-common: remove redundant local variable in damon_migrate_folio_list()

SJ Park <[email protected]>
Newsgroups dev.linux.lists.damon,org.kernel.vger.linux-kernel,org.kvack.linux-mm
Message-ID <[email protected]>
Hello Enze,

get_maintainer.pl suggests to Cc [email protected] too.  Adding it
to Cc list.

On Sat, 18 Jul 2026 08:21:25 +0800 Enze Li <[email protected]> wrote:

> In damon_migrate_folio_list(), we're redeclaring folio inside the first
> while loop, but it just shadows the outer one.  Since the second loop
> uses the outer folio anyway, the inner declaration is pointless.
> 
> Remove it to consistently reuse the same variable throughout the
> function and improve readability.

Nice catch!

> 
> Signed-off-by: Enze Li <[email protected]>

Reviewed-by: SJ Park <[email protected]>

This patch is applied to damon/next [1] tree.  If this patch is not added to
mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew Morton)
to pick this.  So, no action from your side is needed for now.  If it seems I
also forgot doing that or you cannot wait for my action, please feel free to
directly ask that to Andrew.

[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees


Thanks,
SJ

[...]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.