Re: [PATCH] selftests/damon: Add missing NULL checks after malloc()
SJ Park <[email protected]>
| Newsgroups | dev.linux.lists.damon,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
Cc-ing DAMON mailing list. Please Cc DAMON mailing list for DAMON patches. Hello longlong, On Tue, 21 Jul 2026 10:58:02 +0800 longlong yan <[email protected]> wrote: > Add NULL checks after each malloc() call, printing an error message > to stderr and returning -1 on failure. Thank you for this patch! Could you please elaborate why this change is needed, though? What is the user impacting issue that this patch is fixing? Is this fixing a false positive or negative test results? Or, just making the allocation failure easier to find? > > Fixes: b5906f5f7359 ("selftests/damon: add a test for update_schemes_tried_regions sysfs command") > Fixes: c94df805c774 ("selftests/damon: implement a program for even-numbered memory regions access") If this patch is only making the allocation failure easier to detect, I think it is an improvement rather than a fix. If that's the case, I think we don't need above Fixes: tags. If this is a real bug fix, maybe it deserves stable@ porting. Please separate this into two patches for each bug and Cc stable@ for easy stable@ porting. Thanks, SJ [...]