Re: [RFC PATCH 16/17] Docs/admin-guide/mm/damon/usage: document probe preps sysfs files
[email protected] Sat, 25 Jul 2026 21:08:13 +0000
| Newsgroups | dev.linux.lists.damon |
|---|---|
| Message-ID | <[email protected]> |
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Multiple typographical and grammatical errors in the newly added documentation. -- --- Patch [16]: [RFC PATCH 16/17] Docs/admin-guide/mm/damon/usage: document probe preps sysfs files --- commit b237c3e5209fc4981028c7362f98db1f8e443546 Author: SJ Park <[email protected]> Docs/admin-guide/mm/damon/usage: document probe preps sysfs files Update DAMON usage document for the newly added DAMON probe preps sysfs files. > diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst > index da5f9afd08aef..1f5a39e1fc38d 100644 > --- a/Documentation/admin-guide/mm/damon/usage.rst > +++ b/Documentation/admin-guide/mm/damon/usage.rst [ ... ] > @@ -283,9 +286,18 @@ In the beginning, this directory has only one file, ``nr_probes``. Writing a > number (``N``) to the file creates the number of child directories named ``0`` > to ``N-1``. Each directory represents each monitoring probe. > > -In each probe directory, one directory, ``filters`` exists. The directory > -contains files for installing filters for the probe, that is used to determine > -the data attribute for the probe. > +In each probe directory, two directories, ``preps`` and ``filters`` exists. > +The directories contains files for installing probing preparation actions and [Severity: Low] This isn't a bug, but there are grammatical errors here with "exists" and "contains". > +filters for the probe, that is used to determine the data attribute for the > +probe. > + > +In the beginning, ``preps`` directory has only one file, ``nr_preps``. > +Writiing a number (``N``) to the file creates the number of child directories > +names ``0`` to ``N-1``. Each directory represents each preparation action. [Severity: Low] This isn't a bug, but there are typos here with "Writiing" and "names". -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=16