Re: [RFC PATCH 09/17] mm/damon/sysfs: implement preps directory

On Sat, 25 Jul 2026 21:13:38 +0000 [email protected] wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The `damon_sysfs_preps_ktype` static constant is defined but never referenced or attached to the sysfs hierarchy, resulting in an unused variable.
> --
> 
> --- Patch [9]: [RFC PATCH 09/17] mm/damon/sysfs: implement preps directory ---
> commit b804c7747bd623e2ca58a340a5342097faad4841
> Author: SJ Park <[email protected]>
> 
> mm/damon/sysfs: implement preps directory
> 
> This commit implements a sysfs directory and a file for setting DAMON probe
> preps. It implements only the preparatory data structures and functions without
> generating the directories at the moment.
> 
> > diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
> > index 50ff1c172d746..6910a0f31697a 100644
> > --- a/mm/damon/sysfs.c
> > +++ b/mm/damon/sysfs.c
> 
> [ ... ]
> 
> > +static struct attribute *damon_sysfs_preps_attrs[] = {
> > +	&damon_sysfs_preps_nr_attr.attr,
> > +	NULL,
> > +};
> > +ATTRIBUTE_GROUPS(damon_sysfs_preps);
> > +
> > +static const struct kobj_type damon_sysfs_preps_ktype = {
> > +	.release = damon_sysfs_preps_release,
> > +	.sysfs_ops = &kobj_sysfs_ops,
> > +	.default_groups = damon_sysfs_preps_groups,
> > +};
> 
> [Severity: Low]
> This isn't a bug, but since damon_sysfs_preps_ktype is defined here without
> being referenced or attached to the sysfs hierarchy, will this cause unused
> variable compiler warnings?

Good catch.  W=1 build shows the warning.  I will fix this in the next version.

> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=9


Thanks,
SJ