Re: [RFC PATCH 17/17] Docs/ABI/damon: document probe prep sysfs files

On Sat, 25 Jul 2026 21:12:47 +0000 [email protected] wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The documented sysfs ABI path and filename for DAMON probe preparation actions do not match the actual kernel implementation, and the description contains a typographical error.
> --
> 
> --- Patch [17]: [RFC PATCH 17/17] Docs/ABI/damon: document probe prep sysfs files ---
> commit cfe472afe661c1a2901b08aa9b4dfa86ac237ee5
> Author: SJ Park <[email protected]>
> 
> Docs/ABI/damon: document probe prep sysfs files
> 
> This commit updates the DAMON ABI document for the newly added DAMON probe 
> prep sysfs files.
> 
> > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > index e675a57145e36..6d596fb7fa1ff 100644
> > --- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> [ ... ]
> > +What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/probes/<P>/prep/<R>/action
> > +Date:		Jun 2026
> > +Contact:	SJ Park <[email protected]>
> > +Description:	Writing to and reading from this file sets and gets the probing
> > +		preeparation action.
> 
> [Severity: Low]
> Does this documented path match the actual sysfs implementation?
> 
> Looking at damon_sysfs_prep_prep_action_attr in mm/damon/sysfs.c, the 
> attribute file appears to be created as prep_action instead of action, and it
> resides under the preps/ directory instead of prep/. Should the documented 
> path be updated to preps/<R>/prep_action to align with the kernel code?
> 
> This isn't a bug, but there is a typo in the word preeparation.

Nice catches.  I will fix.

> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=17


Thanks,
SJ