Re: [RFC PATCH v2 17/17] Docs/ABI/damon: document probe prep sysfs files

On Sun, 26 Jul 2026 17:45:46 +0000 [email protected] wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The sysfs path for the `prep_action` file is documented incorrectly as `prep/<R>/prep_action` instead of `preps/<R>/prep_action`.
> --
> 
> --- Patch [17]: [RFC PATCH v2 17/17] Docs/ABI/damon: document probe prep sysfs files ---
> commit c668115a6c46349a2601c78b7bdb1229021f721a
> Author: SJ Park <[email protected]>
> 
> Docs/ABI/damon: document probe prep sysfs files
> 
> This commit updates the DAMON ABI documentation to include the newly added 
> DAMON probe prep sysfs files.
> 
> > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-damon b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > index e675a57145e36..f913f4eee4b4d 100644
> > --- a/Documentation/ABI/testing/sysfs-kernel-mm-damon
> > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-damon
> [ ... ]
> > +What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/probes/<P>/preps/nr_preps
> > +Date:		Jun 2026
> > +Contact:	SJ Park <[email protected]>
> > +Description:	Writing a number 'N' to this file creates the number of
> > +		directories for each DAMON probing preparation action named '0'
> > +		to 'N-1' under the preps/ directory.
> > +
> > +What:		/sys/kernel/mm/damon/admin/kdamonds/<K>/contexts/<C>/monitoring_attrs/probes/<P>/prep/<R>/prep_action
> 
> [Severity: Low]
> Is this path missing an 's'? 
> 
> The description above states the directories are created under the preps/
> directory, but this sysfs path uses prep/ instead of preps/. Should this
> be documented as preps/<R>/prep_action to match the actual sysfs directory
> name?

Good catch.  Will fix.

> 
> > +Date:		Jun 2026
> > +Contact:	SJ Park <[email protected]>
> > +Description:	Writing to and reading from this file sets and gets the probing
> > +		preparation action.
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=17


Thanks,
SJ