Re: [RFC PATCH 03/10] mm/damon/vaddr: remove a debug message

On Tue, 28 Jul 2026 05:32:43 +0000 [email protected] wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The 'ctx' parameter in '__damon_va_init_regions()' is now completely unused and should be removed.
> --
> 
> --- Patch [3]: [RFC PATCH 03/10] mm/damon/vaddr: remove a debug message ---
> commit 6f7aa725872ec3ac7c5da1213c336d706d99ebb1
> Author: SJ Park <[email protected]>
> 
> mm/damon/vaddr: remove a debug message
> 
> This commit removes an old debug message in the DAMON virtual address
> space operation set that hasn't been used meaningfully for the last
> few years.
> 
> > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
> > index 4976775fe2762..5ccf70dc8a30b 100644
> > --- a/mm/damon/vaddr.c
> > +++ b/mm/damon/vaddr.c
> > @@ -192,19 +192,10 @@ static int damon_va_three_regions(struct damon_target *t,
> >  static void __damon_va_init_regions(struct damon_ctx *ctx,
> >  				     struct damon_target *t)
> 
> [Severity: Low]
> Since the removal of the debug message also removes the only usage of ctx
> in __damon_va_init_regions(), should we also remove the ctx parameter from
> this static function's signature and update its caller to avoid unused
> parameter warnings?

Good suggestion, I will do so.

> 
> >  {
> > -	struct damon_target *ti;
> >  	struct damon_addr_range regions[3];
> > -	int tidx = 0;
> >  
> > -	if (damon_va_three_regions(t, regions)) {
> > -		damon_for_each_target(ti, ctx) {
> > -			if (ti == t)
> > -				break;
> > -			tidx++;
> > -		}
> > -		pr_debug("Failed to get three regions of %dth target\n", tidx);
> > +	if (damon_va_three_regions(t, regions))
> >  		return;
> > -	}
> >  
> >  	damon_set_regions(t, regions, 3, DAMON_MIN_REGION_SZ);
> >  }
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=3


Thanks,
SJ