Re: [RFC PATCH v1.1 06/10] mm/damon/tests/core-kunit: test overlapping ranges for set_regions()

On Wed, 29 Jul 2026 03:48:22 +0000 [email protected] wrote:

> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Typo in comment: 'alingment' should be 'alignment'.
> --
> 
> --- Patch [6]: [RFC PATCH v1.1 06/10] mm/damon/tests/core-kunit: test overlapping ranges for set_regions() ---
> commit 696ade5451511d51ec415451a2df25bef4d15e9d
> Author: SJ Park <[email protected]>
> 
> mm/damon/tests/core-kunit: test overlapping ranges for set_regions()
> 
> This commit adds a kunit test case to verify that passing overlapping input
> ranges to damon_set_regions() is properly disallowed.
> 
> > diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> > index ac15393a7935b..3041b8288ec26 100644
> > --- a/mm/damon/tests/core-kunit.h
> > +++ b/mm/damon/tests/core-kunit.h
> > @@ -606,6 +606,17 @@ static void damon_test_set_regions(struct kunit *test)
> >  			{.start = 42, .end = 21},
> >  			}, 1, 1,
> >  			(struct damon_addr_range[]){}, 0, -EINVAL);
> > +	/*
> > +	 * Regions resulting in same region after alingment should return
>                                                   ^^^^^^^^^
> 
> [Severity: Low]
> This isn't a bug, but there is a typo here (alingment instead of alignment).

Thank you, I will fix.

> 
> > +	 * -EINVAL.
> > +	 */
> > +	damon_test_set_regions_for(test,
> > +			(struct damon_addr_range[]){}, 0,
> > +			(struct damon_addr_range[]){
> > +			{.start = 10, .end = 20},
> > +			{.start = 20, .end = 30},
> > +			}, 2, 4096,
> > +			(struct damon_addr_range[]){}, 0, -EINVAL);
> >  }
> >  
> >  static void damon_test_update_monitoring_result(struct kunit *test)
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=6


Thanks,
SJ