Re: [PATCH v7 4/7] docs/zh_CN: update DAMON start translation

[email protected]
Newsgroups dev.linux.lists.damon
Message-ID <[email protected]>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The translation removes a valid cross-reference link to the sysfs documentation that is still present in the English original.
- [Low] The translation introduces a command-line flag (`--target_pid`) not present in the corresponding English documentation.
--

--- Patch [4]: [PATCH v7 4/7] docs/zh_CN: update DAMON start translation ---
commit bbfe3c26ebbdef4a642261a8f53c94379a221924
Author: Doehyun Baek <[email protected]>

docs/zh_CN: update DAMON start translation

This commit updates the Chinese translation of the DAMON start documentation
to align with recent upstream changes through commit c9380cdd949d.

> diff --git a/Documentation/translations/zh_CN/admin-guide/mm/damon/start.rst b/Documentation/translations/zh_CN/admin-guide/mm/damon/start.rst
> index cff7b6f98c594..1a7f3382dd158 100644
> --- a/Documentation/translations/zh_CN/admin-guide/mm/damon/start.rst
> +++ b/Documentation/translations/zh_CN/admin-guide/mm/damon/start.rst
> @@ -35,18 +35,63 @@ https://github.com/damonitor/damo找到。下面的例子假设DAMO在你的$PAT
>  这并不是强制性的。
>  
>  因为DAMO使用了DAMON的sysfs接口(详情请参考:doc:`usage`),你应该确保
> -:doc:`sysfs </filesystems/sysfs>` 被挂载。
> +``sysfs`` 被挂载。

[Severity: Low]
Does this change break the documentation cross-reference? The English
original still maintains the functional cross-reference to the sysfs
documentation, so replacing it with a plain code literal here creates an
inconsistency and removes the link in the rendered Chinese document.

[ ... ]

> @@ -117,8 +162,8 @@ https://github.com/damonitor/damo找到。下面的例子假设DAMO在你的$PAT
>  数据访问模式感知的内存管理
>  ==========================
>  
> -以下三个命令使每一个大小>=4K的内存区域在你的工作负载中没有被访问>=60秒,就会被换掉。 ::
> +以下命令使每一个大小>=4K的内存区域在你的工作负载中没有被访问>=60秒,就会被换掉。 ::
>  
> -    $ echo "#min-size max-size min-acc max-acc min-age max-age action" > test_scheme
> -    $ echo "4K        max      0       0       60s     max     pageout" >> test_scheme
> -    $ damo schemes -c test_scheme <pid of your workload>
> +    $ sudo damo start --damos_access_rate 0 0 --damos_sz_region 4K max \
> +                      --damos_age 60s max --damos_action pageout \
> +                      --target_pid <pid of your workload>

[Severity: Low]
Is the --target_pid flag supposed to be added here? The original English
documentation for this section does not include the --target_pid argument
in the command snippet.

If this flag is now required, shouldn't the English original be updated
first rather than introducing it only in the translation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.