Re: [RFC PATCH 2/3] Revert "mm/damon/lru_sort: error out for >10000 active_mem_bp"

[email protected]
Newsgroups dev.linux.lists.damon
Message-ID <[email protected]>
> This reverts commit 06befa61c427e74319781e6f35a364cfc32dbae8.
> 
> The commit was made to avoid zero damos quota goal target value, because
> it can trigger division-by-zero.  Now the core layer handles the corner
> case.  It returns an error for any attempt setting the aero
> target_value.  The corner case handling in DAMON_LRU_SORT is hence no
> more needed.  Remove it.
> 
> Note that this slightly changes the user behavior.  It still disallows
> active_mem_bp of 10,002.  But now it allows other >10,000 active_mem_bp
> values. Setting >10,000 active_mem_bp makes not much sense.  But it
> doesn't cause critical problems such as memory leak or crash, either.
> Arguably that doesn't deserve additional code complexity.  Just allow
> it.
> 
> Signed-off-by: SJ Park <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.