Re: [diamon-discuss] [RFC PATCH CTF 1/3] Clarify that unlisted enum values are implementation-defined

----- On Apr 28, 2020, at 2:51 PM, Mathieu Desnoyers [email protected] wrote:

> ----- On Apr 28, 2020, at 2:40 PM, Philippe Proulx [email protected] wrote:
> 
>> ----- Original Message -----
>>> From: "Mathieu Desnoyers" <[email protected]>
>>> To: "gbastien+lttng" <[email protected]>, "Matthew Khouzam"
>>> <[email protected]>,
>>> [email protected], [email protected], "Jeremie Galarneau"
>>> <[email protected]>
>>> Cc: "lttng-dev" <[email protected]>, "Mathieu Desnoyers"
>>> <[email protected]>
>>> Sent: Thursday, 23 April, 2020 16:52:24
>>> Subject: [RFC PATCH CTF 1/3] Clarify that unlisted enum values are
>>> implementation-defined
>> 
>>> From: Geneviève Bastien <[email protected]>
>>> 
>>> Signed-off-by: Geneviève Bastien <[email protected]>
>>> Signed-off-by: Mathieu Desnoyers <[email protected]>
>>> ---
>>> common-trace-format-specification.md | 3 +++
>>> 1 file changed, 3 insertions(+)
>>> 
>>> diff --git a/common-trace-format-specification.md
>>> b/common-trace-format-specification.md
>>> index fd49e59..f5fea51 100644
>>> --- a/common-trace-format-specification.md
>>> +++ b/common-trace-format-specification.md
>>> @@ -464,6 +464,9 @@ enum {
>>> }
>>> ~~~
>>> 
>>> +The mappings in the enumeration type do not have to be exhaustive.
>>> +Unlisted values are implementation defined.
>>> +
>> 
>> Why not just:
>> 
>>    An enumeration field can have an integral value which its type does not
>>    map to a string.
>> 
>> ?
> 
> Good point, I will use that wording.

Geneviève pointed out on IRC that the sentence above is weird. Would the
following convey the right meaning ?

"An enumeration field can have an integral value for which the associated enumeration
type does not map to a string."

Thanks,

Mathieu

> 
> Thanks,
> 
> Mathieu
> 
>> 
>> Phil
>> 
>>> ### 4.2 Compound types
>>> 
>>> Compound are aggregation of type declarations. Compound types include
>>> --
>> > 2.11.0
> 
> --
> Mathieu Desnoyers
> EfficiOS Inc.
> http://www.efficios.com

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com