Re: [PATCH v4 0/3] crypto: skcipher - per-request multi-data-unit batching
Herbert Xu <[email protected]>
| Newsgroups | dev.linux.lists.dm-devel,org.kernel.vger.linux-block,org.kernel.vger.linux-crypto |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jun 15, 2026 at 03:53:17PM -0700, Eric Biggers wrote: > > So in other words, this series slows down dm-crypt and crypto_skcipher > for everyone to optimize for an out-of-tree driver. And there's also no > benchmark showing that your driver is even worth it over just using the > CPU. There is no reason why the software fallback should be slower than the status quo. Existing callers of the Crypto API will be issuing one indirect function call per data unit. With the new scheme, the indirect calls per unit moves from from the caller into the Crypto API. In fact, we could move it down further and improve upon the status quo by splitting the data in each algorithm implemntation so that the calls per unit become direct function calls and only the overall call into the Crypto API remains indirect. But yes it would be nice to provide numbers for the fallback path to verify that we didn't get this case terribly wrong. Cheers, -- Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt