Re: [PATCHv2 5/6] zloop: set dma_alignment from the backing files for direct I/O
Christoph Hellwig <[email protected]>
| Newsgroups | dev.linux.lists.dm-devel,org.kernel.vger.linux-block,org.kernel.vger.linux-fsdevel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jun 22, 2026 at 10:42:40AM -0700, Keith Busch wrote:
> {
> struct block_device *sb_bdev = zone->file->f_mapping->host->i_sb->s_bdev;
> struct kstat st;
> + bool have_dioalign = !vfs_getattr(&zone->file->f_path, &st,
> + STATX_DIOALIGN, 0) &&
> + (st.result_mask & STATX_DIOALIGN);
This is getting a bit crazy for an assignment :)
Maybe refactor this along the lines of the loop.c code?
> + /* Direct I/O hands the request's pages to the backing files unchanged. */
Overly long line.