Re: [PATCH v5 0/5] crypto: skcipher - multi-data-unit dispatch as a template
Eric Biggers <[email protected]>
| Newsgroups | dev.linux.lists.dm-devel,org.kernel.vger.linux-block,org.kernel.vger.linux-crypto,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260701071919.GA111652@sol> |
On Tue, Jun 30, 2026 at 08:34:26AM +0000, Leonid Ravich wrote: > This is v5. It reworks the multi-data-unit support from the in-core > auto-splitter of v4 into a crypto template, dun(...), addressing the v4 > review: there is now no added cost on the core skcipher path, no > per-algorithm capability flag, and the per-data-unit split lives in an > algorithm rather than in crypto_skcipher_encrypt/decrypt the shape > Herbert suggested, which removes the "overhead for everyone" Eric > objected to. No, this didn't address my feedback. It moved things around but still adds additional overhead for everyone to support an out-of-tree driver, which also hasn't been shown to be any better than just using the CPU. - Eric