Re: [PATCH 06/16] md/raid1: use the atomic queue limit update APIs
Song Liu <[email protected]>
| Newsgroups | dev.linux.lists.drbd-dev,dev.linux.lists.dm-devel,org.kernel.vger.linux-block,org.kernel.vger.linux-raid |
|---|---|
| Message-ID | <CAPhsuW5xaK=WR1RKGpYkSzHW8TOMbUwY-KeTD=kD3otQFZZV0Q@mail.gmail.com> |
On Tue, Feb 27, 2024 at 7:26 AM Christoph Hellwig <[email protected]> wrote: > > On Mon, Feb 26, 2024 at 07:29:08PM +0800, Yu Kuai wrote: > > Hi, > > > > 在 2024/02/26 18:29, Christoph Hellwig 写道: > >> Build the queue limits outside the queue and apply them using > >> queue_limits_set. Also remove the bogus ->gendisk and ->queue NULL > >> checks in the are while touching it. > > > > The checking of mddev->gendisk can't be removed, because this is used to > > distinguish dm-raid and md/raid. And the same for following patches. > > Ah. Well, we should make that more obvious then. This is what I > currently have: > > http://git.infradead.org/?p=users/hch/block.git;a=shortlog;h=refs/heads/md-blk-limits > > particularly: > > http://git.infradead.org/?p=users/hch/block.git;a=commitdiff;h=24b2fd15f57f06629d2254ebec480e1e28b96636 Yes! I was thinking about something like mddev_is_dm() to make these checks less confusing. Thanks! Song