Re: [PATCH 15/26] block: move the add_random flag to queue_limits

Hannes Reinecke <[email protected]>
Newsgroups dev.linux.lists.drbd-dev,dev.linux.lists.dm-devel,dev.linux.lists.nvdimm,dev.linux.lists.virtualization,org.infradead.lists.linux-mtd,org.infradead.lists.linux-nvme,org.infradead.lists.linux-um,org.kernel.vger.ceph-devel,org.kernel.vger.linux-bcache,org.kernel.vger.linux-block,org.kernel.vger.linux-m68k,org.kernel.vger.linux-mmc,org.kernel.vger.linux-raid,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.ozlabs.lists.linuxppc-dev,org.xenproject.lists.xen-devel
Message-ID <[email protected]>
On 6/17/24 08:04, Christoph Hellwig wrote:
> Move the add_random flag into the queue_limits feature field so that it
> can be set atomically with the queue frozen.
> 
> Note that this also removes code from dm to clear the flag based on
> the underlying devices, which can't be reached as dm devices will
> always start out without the flag set.
> 
> Signed-off-by: Christoph Hellwig <[email protected]>
> Reviewed-by: Damien Le Moal <[email protected]>
> ---
>   block/blk-mq-debugfs.c            |  1 -
>   block/blk-sysfs.c                 |  6 +++---
>   drivers/block/mtip32xx/mtip32xx.c |  1 -
>   drivers/md/dm-table.c             | 18 ------------------
>   drivers/mmc/core/queue.c          |  2 --
>   drivers/mtd/mtd_blkdevs.c         |  3 ---
>   drivers/s390/block/scm_blk.c      |  4 ----
>   drivers/scsi/scsi_lib.c           |  3 +--
>   drivers/scsi/sd.c                 | 11 +++--------
>   include/linux/blkdev.h            |  5 +++--
>   10 files changed, 10 insertions(+), 44 deletions(-)
> 
Reviewed-by: Hannes Reinecke <[email protected]>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
[email protected]                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.