Re: [PATCH v2 1/2] build: changing SUSE release file

On Thu, May 15, 2025 at 10:48:14AM +0800, Heming Zhao wrote:
> This commit changes /etc/SuSe-release to /etc/os-release.
> The SuSe-release file disappeared a long time ago.
> 
> Signed-off-by: Heming Zhao <[email protected]>
> ---
>  configure.ac | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 282fdf1584e3..883fe3e5cdb3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -402,7 +402,7 @@ else
>     if test -z $DISTRO; then
>        AC_CHECK_FILE(/etc/redhat-release, [DISTRO="redhat"])
>        AC_CHECK_FILE(/etc/debian_version, [DISTRO="debian"])
> -      AC_CHECK_FILE(/etc/SuSE-release, [DISTRO="suse"])
> +      AC_CHECK_FILE(/etc/os-release, [DISTRO="suse"])

Hi,

everything that has a /etc/os-release (which by now is basically every
distribution on this planet) is suse? No.

This (not only this) part of the automagic in drbd-utils is a mess and
I'm currently in the process of cleaning that up a bit. I will not take
this patch as is, IMO it is just wrong, please just wait, this should
improve in a week or two.

Regards, rck