Re: [PATCH] drbd: add missing kref_get in handle_write_conflicts

Jens Axboe <[email protected]> Tue, 08 Jul 2025 12:00:14 -0600
Newsgroups dev.linux.lists.drbd-dev,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Fri, 27 Jun 2025 11:57:28 +0200, Christoph Böhmwalder wrote:
> With `two-primaries` enabled, DRBD tries to detect "concurrent" writes
> and handle write conflicts, so that even if you write to the same sector
> simultaneously on both nodes, they end up with the identical data once
> the writes are completed.
> 
> In handling "superseeded" writes, we forgot a kref_get,
> resulting in a premature drbd_destroy_device and use after free,
> and further to kernel crashes with symptoms.
> 
> [...]

Applied, thanks!

[1/1] drbd: add missing kref_get in handle_write_conflicts
      commit: 00c9c9628b49e368d140cfa61d7df9b8922ec2a8

Best regards,
-- 
Jens Axboe