Re: [PATCH] drbd: remove DRBD_GENLA_F_MANDATORY flag handling

Jens Axboe <[email protected]> Mon, 06 Apr 2026 20:22:13 -0600

Newsgroups	dev.linux.lists.drbd-dev,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel
Message-ID	<177552853342.149947.7297762019080456826.b4-ty@b4>

On Fri, 03 Apr 2026 15:29:53 +0200, Christoph Böhmwalder wrote:
> DRBD used a custom mechanism to mark netlink attributes as "mandatory":
> bit 14 of nla_type was repurposed as DRBD_GENLA_F_MANDATORY. Attributes
> sent from userspace that had this bit present and that were unknown
> to the kernel would lead to an error.
> 
> Since commit ef6243acb478 ("genetlink: optionally validate strictly/dumps"),
> the generic netlink layer rejects unknown top-level attributes when
> strict validation is enabled. DRBD never opted out of strict
> validation, so unknown top-level attributes are already rejected by
> the netlink core.
> 
> [...]

Applied, thanks!

[1/1] drbd: remove DRBD_GENLA_F_MANDATORY flag handling
      commit: a9c4b1d37622ed01b75f94a4f68cf55f33153a31

Best regards,
-- 
Jens Axboe