Re: [PATCH] drbd: remove unused drbd_nl_mcgrps[] array

Christoph Böhmwalder <[email protected]> Tue, 19 May 2026 22:51:44 +0200

Newsgroups	dev.linux.lists.drbd-dev,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On 5/19/26 22:30, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
> 
> After the rework, two files have a copy of drbd_nl_mcgrps[], but one
> of them has no references:
> 
> drivers/block/drbd/drbd_nl_gen.c:641:42: error: 'drbd_nl_mcgrps' defined but not used [-Werror=unused-const-variable=]
>    641 | static const struct genl_multicast_group drbd_nl_mcgrps[] = {
>        |                                          ^~~~~~~~~~~~~~
> 
> At the default warning level, -Wunused-const-variables is turned off,
> so this has gone unnoticed.
> 
> Remove the extra variable.
> 
> Fixes: 8098eeb693c4 ("drbd: replace genl_magic with explicit netlink serialization")
> Signed-off-by: Arnd Bergmann <[email protected]>

Oops, looks like a copy/paste error on my side.
Thanks for noticing and fixing.

Reviewed-by: Christoph Böhmwalder <[email protected]>