Re: [PATCH 3/8] iommu/fsl: use platform_device_set_fwnode()
Robin Murphy <[email protected]>
| Newsgroups | dev.linux.lists.driver-core,dev.linux.lists.imx,dev.linux.lists.iommu,dev.linux.lists.mfd,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-i2c,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm,org.kernel.vger.linux-sound,org.kernel.vger.netdev,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
On 20/07/2026 10:24 am, Bartosz Golaszewski wrote: > Prefer the higher-level platform_device_set_fwnode() over the > OF-specific platform_device_set_of_node() for dynamically allocated > platform devices. This is very much non-portable code specific to OF-only platforms, but if the intention is to remove platform_device_set_of_node() again already, then FWIW, Acked-by: Robin Murphy <[email protected]> (Although I'm slightly puzzled by the cover letter - AFAICS in -next, platform_device_set_of_node() is itself very much a user of platform_device_set_fwnode(), however in terms of symbol exports, perhaps the former could now just be a static inline wrapper?) > Signed-off-by: Bartosz Golaszewski <[email protected]> > --- > drivers/iommu/fsl_pamu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c > index c83bbc3faad56d6ee1c89b0a7f74028af02c81e9..268a1f752fbceab4fd24013aeea5df1b6982fbb1 100644 > --- a/drivers/iommu/fsl_pamu.c > +++ b/drivers/iommu/fsl_pamu.c > @@ -975,7 +975,7 @@ static __init int fsl_pamu_init(void) > goto error_device_alloc; > } > > - platform_device_set_of_node(pdev, np); > + platform_device_set_fwnode(pdev, of_fwnode_handle(np)); > > ret = pamu_domain_init(); > if (ret) >