Re: [PATCH v6 16/16] arm64: dts: mediatek: mt8188-geralt: Add WiFi/BT as M.2 E-key slot
Bartosz Golaszewski <[email protected]>
| Newsgroups | dev.linux.lists.driver-core,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-mediatek,org.kernel.vger.linux-acpi,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm,org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <CAMRc=Mfv7P74+cpvmHaF=aSYLO=RtFbxenJHMrCjgOMoHuLvQQ@mail.gmail.com> |
On Tue, 21 Jul 2026 08:54:11 +0200, Chen-Yu Tsai <[email protected]> said: > The MT8188 Geralt design features a chip-on-board WiFi/BT solution. This > is a M.2 E-key WiFi/BT board layout directly inserted into the mainboard > design. The connections to the rest of the board are almost the same as > if it were a separate M.2 card. The only addition is the PMU_EN pin on > the chip; on M.2 cards this would be tied to the primary power source. > > Model the chip-on-board WiFi/BT solution as a M.2 E-key slot with PCIe, > USB and auxiliary signals. The PMU_EN pin, which enables the internal > power controls and regulators, is modeled as a regulator fed by the > pp3300_wlan regulator. Since power sequencing is now correctly modeled > using the M.2 E-key slot, drop the "regulator-always-on" property one > pp3300_wlan regulator. Also drop the comment in xhci2 saying "MT7921's > power is controlled by PCIe". > > Also drop the voltage range on the pp3300_wlan regulator. This > "regulator" is just a load switch and does not provide any regulation. > > Signed-off-by: Chen-Yu Tsai <[email protected]> > --- Reviewed-by: Bartosz Golaszewski <[email protected]>