Re: [PATCH] fwnode: add missing kernel-doc for struct fwnode_operations members

On 7/27/26 1:27 PM, Danilo Krummrich wrote:
> Document the four undocumented struct members in
> struct fwnode_operations: device_dma_supported, device_get_dma_attr,
> iomap, and irq_get.
> 
> This avoids kernel-doc warnings once include/linux/fwnode.h is included
> in the driver-api infrastructure documentation.
> 
> Signed-off-by: Danilo Krummrich <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>
Tested-by: Randy Dunlap <[email protected]>

Thanks.

> ---
>  include/linux/fwnode.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 4e86e6990d28..a9dcaf7e7076 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -117,6 +117,8 @@ struct fwnode_reference_args {
>   * @put: Put a reference to an fwnode.
>   * @device_is_available: Return true if the device is available.
>   * @device_get_match_data: Return the device driver match data.
> + * @device_dma_supported: Return true if DMA is supported.
> + * @device_get_dma_attr: Return the device DMA attribute.
>   * @property_present: Return true if a property is present.
>   * @property_read_bool: Return a boolean property value.
>   * @property_read_int_array: Read an array of integer properties. Return zero on
> @@ -134,6 +136,8 @@ struct fwnode_reference_args {
>   *			       endpoint node.
>   * @graph_get_port_parent: Return the parent node of a port node.
>   * @graph_parse_endpoint: Parse endpoint for port and endpoint id.
> + * @iomap: Map the I/O memory of a given index for a fwnode.
> + * @irq_get: Get the IRQ of a given index for a fwnode.
>   * @add_links:	Create fwnode links to all the suppliers of the fwnode. Return
>   *		zero on success, a negative error code otherwise.
>   */

-- 
~Randy