Re: [PATCH v5 8/8] gpu: nova-core: update firmware module info for TLV images
Timur Tabi <[email protected]> Tue, 28 Jul 2026 21:54:51 +0000
| Newsgroups | dev.linux.lists.driver-core,dev.linux.lists.nova-gpu,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
On 7/27/26 3:06 AM, Alexandre Courbot wrote: > On Sat Jul 11, 2026 at 8:04 AM JST, Timur Tabi wrote: >> Now that nova-core loads the TLV firmware images, update the firmware >> module info to specify those files. >> >> Also remove FIRMWARE_VERSION as it is no longer used. >> >> Signed-off-by: Timur Tabi <[email protected]> > > Doing this in one go creates a potential bisectability issue: there are > points in the history where the firmware entries do not reflect the > actual firmware files used. True, but that only used for making initramfs. I have a hard time believing that this will actually matter. > Can you fold this patch gradually into the respective patches (4-7) to > avoid this? Sure, but that will create a lot of churn in make_entry_chipset() and boot_firmware_files(). > Also, preemptively: note that the latest drm-rust-next introduces a > helper `boot_firmware_files` function to get a list of files relevant to > a given chipset. This list will have to be updated to include the `.tlv` > suffix. Already done for v6.